Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Azure General icon set #155

Merged
merged 6 commits into from
May 21, 2020
Merged

Add Azure General icon set #155

merged 6 commits into from
May 21, 2020

Conversation

aymond
Copy link
Contributor

@aymond aymond commented May 19, 2020 •
edited
Loading

Official Microsoft Icon Set (https://www.microsoft.com/en-us/download/details.aspx?id=41937)
256x256 Size
png format
All tests passed
autogen.sh used

Related Issues
#137
#143

Test Results

(.venv) aymon@DESKTOP-8KMEG1T:~/projects/diagrams$ python -m unittest tests/*.py -v
test_node_not_in_diagram (tests.test_diagram.ClusterTest) ... ok
test_node_to_node (tests.test_diagram.ClusterTest) ... ok
test_node_to_nodes (tests.test_diagram.ClusterTest) ... ok
test_nodes_to_node (tests.test_diagram.ClusterTest) ... ok
test_validate_direction (tests.test_diagram.ClusterTest) ... ok
test_with_global_context (tests.test_diagram.ClusterTest) ... ok
test_with_nested_cluster (tests.test_diagram.ClusterTest) ... ok
test_custom_filename (tests.test_diagram.DiagramTest) ... ok
test_default_filename (tests.test_diagram.DiagramTest) ... ok
test_node_not_in_diagram (tests.test_diagram.DiagramTest) ... ok
test_node_to_node (tests.test_diagram.DiagramTest) ... ok
test_node_to_nodes (tests.test_diagram.DiagramTest) ... ok
test_nodes_to_node (tests.test_diagram.DiagramTest) ... ok
test_validate_direction (tests.test_diagram.DiagramTest) ... ok
test_validate_outformat (tests.test_diagram.DiagramTest) ... ok
test_with_global_context (tests.test_diagram.DiagramTest) ... ok
test_node_to_node (tests.test_diagram.EdgeTest) ... ok
test_node_to_node_with_additional_attributes (tests.test_diagram.EdgeTest) ... ok
test_node_to_node_with_attributes (tests.test_diagram.EdgeTest) ... ok
test_node_to_nodes (tests.test_diagram.EdgeTest) ... ok
test_nodes_to_node (tests.test_diagram.EdgeTest) ... ok
test_nodes_to_node_with_additional_attributes (tests.test_diagram.EdgeTest) ... ok
test_nodes_to_node_with_additional_attributes_directional (tests.test_diagram.EdgeTest) ... ok
test_nodes_to_node_with_attributes_bidirectional (tests.test_diagram.EdgeTest) ... ok
test_nodes_to_node_with_attributes_bothdirectional (tests.test_diagram.EdgeTest) ... ok
test_nodes_to_node_with_attributes_loop (tests.test_diagram.EdgeTest) ... ok
test_nodes_to_node_with_attributes_onedirectional (tests.test_diagram.EdgeTest) ... ok

----------------------------------------------------------------------
Ran 27 tests in 0.861s

OK

image

from diagrams import Diagram
from diagrams.azure.general import ManagementGroups

with Diagram("Azure Test", show=False, direction="TB"):
        ManagementGroups("core") >> [ManagementGroups("dev"),ManagementGroups("test"),ManagementGroups("sim"),ManagementGroups("prod")]

@mingrammer
Copy link
Owner

Image size doesn't seem to fit 256x256. Please check it.

@mingrammer mingrammer added area/provider/azure Azure provider comp/node Issue of node component kind/feat/icon Icon request labels May 20, 2020
@aymond
Copy link
Contributor Author

aymond commented May 20, 2020

Not sure what happened.

$ ls -A1 | xargs file
allresources.png:     PNG image data, 256 x 256, 8-bit colormap, non-interlaced
azurehome.png:        PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
developertools.png:   PNG image data, 256 x 275, 8-bit/color RGBA, non-interlaced
helpsupport.png:      PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
information.png:      PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
managementgroups.png: PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
marketplace.png:      PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
quickstartcenter.png: PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
recent.png:           PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
reservations.png:     PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
resource.png:         PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
resourcegroups.png:   PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
servicehealth.png:    PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
shareddashboard.png:  PNG image data, 256 x 209, 8-bit/color RGBA, non-interlaced
subscriptions.png:    PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
support.png:          PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
supportrequests.png:  PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
tag.png:              PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
tags.png:             PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
templates.png:        PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
twousericon.png:      PNG image data, 256 x 258, 8-bit/color RGBA, non-interlaced
userhealthicon.png:   PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
usericon.png:         PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
userprivacy.png:      PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
userresource.png:     PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced
whatsnew.png:         PNG image data, 256 x 256, 8-bit/color RGBA, non-interlaced

@mingrammer
Copy link
Owner

mingrammer commented May 21, 2020 •
edited
Loading

It now looks correctly. Thank you.

mingrammer
mingrammer approved these changes May 21, 2020
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for adding it :)

@mingrammer mingrammer merged commit d0347a9 into mingrammer:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingrammer mingrammer mingrammer approved these changes

Assignees
No one assigned
Labels
area/provider/azure Azure provider comp/node Issue of node component kind/feat/icon Icon request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aymond @mingrammer